Codecov Report

Merging #51 (5bfef85) into master (59d87d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files          13       13           
  Lines         832      832           
=======================================
  Hits          712      712           
  Misses        120      120           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d87d0...5bfef85. Read the comment docs.

If you're doing this I expect you'll need to add 3.6 to the CI runs as well? We test with all the other supported versions.

You may not want to/be able to until PR #49 is merged though, as that contains a lot of CI changes from Tom at the moment.

It looks like I broke some tests, I'll investigate the best way to fix it

It's actually a problem in aioca with: from __future__ import annotations
I'm tempted to remove that line.

Sounds reasonable, if you add python 3.6 to the aioca build matrix then we'll know if that's all that needs changing...

Given that DiamondLightSource/aioca#19 was merged, this change is easier, though it will have to wait for next release

aioca 1.3 is now released for Python 3.6

Thanks Tom, I added the version constraint for aioca and CI looks happy now